Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for ABCL #14

Closed
wants to merge 3 commits into from
Closed

Patches for ABCL #14

wants to merge 3 commits into from

Conversation

easye
Copy link
Contributor

@easye easye commented Oct 29, 2012

Please consider the referenced patches for inclusion in CFFI in time for the November Quicklisp as they represent substantial improvement over the current version including no longer needing to specify a restart on reloading a compiled system and the beginnings of a fix for the callbacks.

There is also a considerably more speculative patch to get the CFFI-TESTS to work under contemporary Solaris installations using the GCC toolchain running 64bit Lisp implementations.

The "-fPIC" flag will always be necessary when using GCC-derived compilers as I understand it.

Additionally, Solaris compilation options now unconditionally tries a
64bit build.  Contemporary Solaris (since Solaris 10), are hybrid
32/64 bit environments where "uname -m" reports "i86pc".  Whether one
wants the 32 or 64 bit version of the libraries depends on the type of
the Lisp implementation doing the loading, which is currently not
available in the environment in which make(1) is executing.
…r ABCL.

The interactive restart when reloading callbacks is no longer needed.

A callable function pointer is now returned by CALLBACK and
GET-CALLBACK, which wasn't the case previously.

Now down to 25 failing tests!

Callbacks "automacro-ly" now get a translation layer to convert back
from native types to ones which ABCL expects.  This translation is
currently a work in progress, as not all cases are covered correctly.

(Stas Boukarev) MAKE-FUNCTION-POINTER typo.

Refactored to remove compile warnings about MAKE-IMMEDIATE-OBJECT.

CFFI-SYS::%LOAD-FOREIGN-LIBRARY tries harder to figure out which
library to load.

Docstrings added.
@liamh
Copy link
Member

liamh commented Oct 30, 2012

Quicklisp is pulled from released versions of CFFI (currently 0.10.7.1),
not from master HEAD. So there would have to be a release of CFFI to make
it into quicklisp.

On Mon, Oct 29, 2012 at 11:24 AM, easye notifications@github.com wrote:

Please consider the referenced patches for inclusion in CFFI in time for
the November Quicklisp as they represent substantial improvement over the
current version including no longer needing to specify a restart on
reloading a compiled system and the beginnings of a fix for the callbacks.

There is also a considerably more speculative patch to get the CFFI-TESTS
to work under contemporary Solaris installations using the GCC toolchain

running 64bit Lisp implementations.

You can merge this Pull Request by running:

git pull https://github.com/easye/cffi master

Or view, comment on, or merge it at:

#14
Commit Summary

  • Fix Solaris compilation options.
  • cffi-abcl-20121028a: changes to cffi_0.10.7.1 Quicklisp 2012-10-13
    fo…
  • Arguments to CONCATENATE need to be sequences.

File Changes

  • M grovel/invoke.lisp (2)
  • M src/cffi-abcl.lisp (162)
  • M tests/GNUmakefile (2)

Patch Links

@easye
Copy link
Contributor Author

easye commented Oct 30, 2012

Is there anything I could do to facilitate a release which includes these patches?

@luismbo
Copy link
Member

luismbo commented Nov 4, 2012

Pushed your changes. Thanks!

@luismbo luismbo closed this Nov 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants