cffi-toolchain: don't reintroduce bugs to ECL's ASDF #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECL has a ASDF forked from version 3.1.7 version and tags it as 3.1.8 (to avoid confusion, official release following 3.1.7 is 3.2.0). This version has some bugs fixed (especially regarding bundles) for ECL, so loading this file reintroduces said issues. Since there is no "official" ASDF 3.1.8 release this change doesn't impact anything except ECL. Issue in question is regression with init names, monolithic bundles and file causes all systems depending on it to loaded twice before they really are compiled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECL has a ASDF forked from version 3.1.7 version and tags it as
3.1.8 (to avoid confusion, official release following 3.1.7 is
3.2.0). This version has some bugs fixed (especially regarding
bundles) for ECL, so loading this file reintroduces said issues. Since
there is no "official" ASDF 3.1.8 release this change doesn't impact
anything except ECL.
Issue in question is regression with init names, monolithic bundles
and file causes all systems depending on it to loaded twice before
they really are compiled.