Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading cffi as monolithic compile-bundle into a clean Lisp #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gendl
Copy link

@gendl gendl commented Apr 17, 2023

Protect against loading this as a monolithic compile bundle which doesn't have asdf in it.

@luismbo
Copy link
Member

luismbo commented Apr 17, 2023

Does that fail when the fasl references an inexistent ASDF package? Two suggestions: drop the commented out code and maybe use uiop:symbol-call?

@gendl
Copy link
Author

gendl commented Apr 17, 2023

Hi Luis,

The original version was causing builds to fail if the build is using a compile bundle (asdf's monolithic-compile-bundle-op) for cffi, but where asdf itself had not been loaded into the build, e.g. for runtime builds where we don't need the asdf or quicklisp tooling itself included in the build.

I deleted the commented-out previous line and my comment, added a check for existence of asdf package, and changed the (funcall (read-from-string ...))`` into uiop:symbol-call` as directed.

Please advise re any further suggestions,

Thanks,

Dave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants