MISSING_VAR not caught for undeclared struct

[KamasamaK]

Using a structure without first declaring it as a struct does not trigger this rule. Below are some examples of first use within a function.

Reported:

• <cfset tokenizedAddress = {}>
• tokenizedAddress = {};

Unreported:

• <cfset tokenizedAddress.streetName = streetName>
• tokenizedAddress.streetName = streetName;
• <cfset tokenizedAddress["streetName"] = streetName>
• tokenizedAddress["streetName"] = streetName;

[ryaneberly]

Wow, I didn't even know that was legitimate CF code. Seems to cross the line into territory that is too forgiving of bad coding :). Definitely worth linting.

[KamasamaK]

@ryaneberly I agree, and that should probably be its own rule so I've made a proposal in Issue #406. However, this rule should only be concerned with catching variables not declared in the local scope.

[ryaneberly]

so we can close this one?

[KamasamaK]

@ryaneberly For what reason? I just checked the latest dev build and did not see this fixed. I also got a number of PLUGIN_ERROR reports, so it's possible something is breaking it if it's supposed to be fixed. But I notice you did not tag this issue in a commit, which you normally do.

[ryaneberly]

@KamasamaK ,
Maybe I misunderstood. What are we fixing in this issue that is not covered in #406?

  Can you provide a little more info on the PLUGIN_ERRORs you are seeing?

[KamasamaK]

As I said in my initial response, they have different purposes. That other rule is just recommending that you declare a variable as a struct or array type before using it with the dot or array notation. If they carry out that recommendation, then the lack of local scoping will be caught by MISSING_VAR as it is now. But they may choose to ignore or exclude it. There might be people who run CFLint and only include the MISSING_VAR rule because that's all they care about. While I wouldn't recommend using a struct or array without a type declaration, it is valid CFML and this rule should report those variables if they are not local scoped.

[ryaneberly]

Well said. Thanks @KamasamaK

[ryaneberly]

see https://github.com/cflint/CFLint/tree/missingVar_404

[ryaneberly]

@KamasamaK . This seems to be working per the tests added in 8680345