Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-quiet reports some internal parsing/ANTLR messaging #526

Closed
TheRealAgentK opened this issue Jan 2, 2018 · 9 comments
Closed

-quiet reports some internal parsing/ANTLR messaging #526

TheRealAgentK opened this issue Jan 2, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@TheRealAgentK
Copy link
Collaborator

... a leftover from #329:

I occasionally get messages like this (even in -q mode)

"line 1:3 no viable alternative at input 'GCfailed'"

Are they coming from cfparser? Or would those be generated in cflint somewhere? Maybe through ANTLR? Just trying to get an understanding where I could control their appearance. @ryaneberly

@TheRealAgentK TheRealAgentK added this to the 1.3.1 milestone Jan 2, 2018
@ryaneberly
Copy link
Contributor

That's definitely ANTLR. I think we have to hook in the the ANTLR logging mechanism to eat that one.

https://stackoverflow.com/questions/25990158/antlr-4-avoid-error-printing-to-console

@ryaneberly
Copy link
Contributor

That might need to happen at the cfparser level....

@TheRealAgentK
Copy link
Collaborator Author

Ok, if it's too hard and messy then let's leave the ticket open but not do anything about it for now. It'd have just been nice to be truly quiet with -q. But I'm not even sure what the demand for this -q functionality is...

TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jan 3, 2018
TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jan 3, 2018
@TheRealAgentK
Copy link
Collaborator Author

Documented that ANTLR/CFParser might push out text even if CFLint runs quietly.

@TheRealAgentK TheRealAgentK removed this from the 1.3.1 milestone Jan 3, 2018
@ryaneberly
Copy link
Contributor

I think it's worth doing and not too hard. I may enter an echo ticket in the cfparser project if needed.

@ryaneberly
Copy link
Contributor

fixed in cfparser 2.6.1 , release and should hit maven this weekend.

@TheRealAgentK
Copy link
Collaborator Author

Awesome @ryaneberly - so I'll just need to update the dependency in CFLint to 2.6.1 in a couple of days?

@ryaneberly
Copy link
Contributor

right. keep an eye on maven.

@ryaneberly ryaneberly added this to the 1.4.0 milestone Jun 1, 2018
@ryaneberly ryaneberly modified the milestones: 1.4.0, 1.4.1 Jun 2, 2018
@ryaneberly
Copy link
Contributor

Moving to 1.4.1 since it looks like 1.4.0 is running on cfparser 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants