Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COSPv1.4 interface #44

Closed
dustinswales opened this issue May 11, 2020 · 5 comments
Closed

Remove COSPv1.4 interface #44

dustinswales opened this issue May 11, 2020 · 5 comments

Comments

@dustinswales
Copy link
Contributor

As part of the COSP2 release we provided a "drop-in replacement" interface that would allow COSP1 users to use the new COSP2 code with little interruption on their side. Essentially the role of this interface was to map derived data types (DDTs) used in COSP1 to the DDTs used in COSP2.
This interface was maintained up until COSPv2.0.3, consistent with the last release of COSP1, v1.4.3.
However, many developments have been added to the COSP2 repository since, the latest version is v2.1.6, and this interface is no longer compatible with these later versions of COSP2, v2.1 and later. Supporting this interface beyond v2.0.3 isn't sensible as the new diagnostics will not be available to users of the COSP1 code base.
We (Robert and I) propose we remove this deprecated code from the current COSP2 code base.

@alejandrobodas
Copy link
Collaborator

@dustinswales @RobertPincus I think this makes sense, so +1 from me. Given that not everyone watches the repository, it may be worth pointing the PMC to this issue?

@alejandrobodas
Copy link
Collaborator

@dustinswales I am implementing some changes to address #43 and I have a question regarding CMOR. Is the CMOR implementation still functional or it only works with the v1.4 interface? I am trying to understand if the CMOR outputs are going to go away with this issue or they will still be retained.

@RobertPincus
Copy link
Contributor

RobertPincus commented May 12, 2020 via email

@dustinswales
Copy link
Contributor Author

@alejandrobodas
We said goodbye to CMOR at v2.1, same time we stopped maintaining the v1.4 interface. We replaced the offline driver w/ straight netCDF output.

@alejandrobodas
Copy link
Collaborator

I had forgotten about that, thanks for the clarification.

dustinswales pushed a commit that referenced this issue Jun 3, 2020
Removing COSP 1.4 interface. Closes #44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants