-
Notifications
You must be signed in to change notification settings - Fork 29
-
Notifications
You must be signed in to change notification settings - Fork 29
[VZ] Overview #197
Comments
@cfpb/front-end-team-admin Concrete user stories came out of yesterday's discussions. Acceptance criteria is still emerging. Hit me up here or on chat with any questions/concerns. |
This is great. A couple thoughts:
@contolini mentions most of this already, just want to second it and mention some of my pain points. |
Thanks for your thoughts, @awolfe76!
What slows you down with the current stuff we have?
If you use the generator, you get that in the form of our |
To be honest, it was a while back and I would have to try to build something with it again to really try to give you details. Which I'll do to be more helpful. But from what I do remember, it took me a while to wrap my head around everything that was happening in the build process (maybe that was me?) but I don't think that it should take time to do. Could be more apparent. I did need to make tweaks to the Grunt tasks for my project needs ... all related to my 2nd bullet. Where to place overrides and have them included. I think you and I together eventually worked through this. 😄 But this seems like it shouldn't be required, at least very much, when working on a CFPB project. I found it hard to discover what was possible. Maybe some cleaner documentation would help. Documentation seems like an ongoing pain point for most. Using bootstrap as an example, their docs are easy to navigate and easy to see exactly what you can do, and how to do it. But also, having built things with bootstrap in the past I don't think the documentation was always required. Something about the code base made it clear what you could do with it. Hard to say exactly what that was/is, but again, I'll try something with CF again to see.
Having one repo, so only one file with variables, seems to do this better. May even remove the need for the generator? If it's one repo, you build and include the right files. I tend to dig through Github to find things quite a bit (prior to use and even during) and tracking down where a variable was set proved difficult at times. |
@awolfe76 I really like the theme of "speed" for this release. And I think you're right that having clear documentation in a single location will do wonders. |
🙋🏽I've been working in CF since March and I still struggle to debug the build process. I keep forgetting about cf-grunt-config and it's not really clearly documented anywhere. Moving to one repo removes the need for that forgotten grunt repo. We have all our gulp tasks in one separated out folder and it's nice. 👌🏽 |
There's an interesting parallel discussion thing happening now. @awolfe76 is talking mostly about consuming the framework, but @KimberlyMunoz's point (and the driving force between all the "single repo" talk), is about making it easier for contributors to CF. @awolfe76 On vars/overrides: This is where the generator shines. It provides you with a project ready to roll that is set up with CFPB styling in a single All your points about unclear/missing documentation are definitely well-taken! |
@Scotchester Agreed and those two discussion points conveniently align nicely with the two user stories at the top of this page. |
I think of these as the same, we build it, we use it, we build it while using it. Using it is the only way to understand how/what to contribute back, outside of design change of course. A lot of the things I've seen mentioned, here and in other issues, help all around. Documentation, cleaner build, cleaner structure, etc. |
The only issue is when you don't know where a variable came from or what it does. Having everything in one vars file would make it a lot easier to understand relationships, especially when we use one variable as the value for another variable. |
I'm not clear what you're proposing. How do all the vars get more in a single file? |
Not to speak for @jimmynotjim ... but from a contributing stand point they aren't in one file. They are scattered through repos and difficult to track down. When consuming and using the generator, yes, one file can't be made smaller. 😉 |
@awolfe76 Yeah, clarified that with @jimmynotjim via chat. Again, the consumption/contribution tension... I suggest that we put this specific discussion (variables all in one file) on hold until we figure out if the single-repo solution is viable. That will definitely impact what can/can't be done. |
👍 one step at a time. |
@contolini not sure where else to put this but i added some fixes to yr VZ branch https://github.com/contolini/capital-framework/compare/voltrazord...cfarm:voltrazord?expand=1 |
@cfarm You could submit a PR to his fork with those :) |
@cfarm @Scotchester Let's open PRs against cfpb's voltrazord branch because there's some history wonkiness with mine. |
Didn't know which issue was best for this, but just came across MailChimp's Doc site and a few things I think we could borrow. First is breaking apart the more friendly guides and the more technical docs. This would make the project much more approachable to new users while still allowing seasoned users to find code details. Second is the playground. Hosting a live playground on CodePen and embedding them into our site would allow anyone to test out the project, or even just a component, without having to dive in and build it locally, again, making it much more approachable to new users. |
I believe this is closed now that Voltrazord is done. @jimmynotjim Could you move your last comment to a more doc-centric issue? |
CFv2 will be a substantial restructuring tracked with the Voltrazord milestone. The goal of this release is speed. Using CF quickly, contributing to CF quickly, squashing CF bugs quickly.
Guiding Stories
As a CFPB front-end web developer,
I want to copy/paste CF HTML snippets,
So that I can quickly and confidently build UIs.
As a CFPB front-end web developer,
I want CF source code to live in one place,
So that contributing to the framework is straightforward.
Acceptance Criteria
npm i cf-buttons
).CONTRIBUTING.md
in this repo.Auto-push component updates to discrete component repos using a botNot doing this.Known obstacles:
Maintaining Bower support will be tricky. Bower, unlike npm, doesn't store package tarballs. This means every component needs its own repo. Some frameworks handle this through scripted pusher bots. Other frameworks simply don't support independent component installation via Bower.After following the discussion on LockFile Feature bower/bower#1748, wherein it is revealed that there is only one maintainer remaining on the Bower project, and its future hinges on the success of a patronage-based model, we decided to drop support for Bower.See #168 for a history of what went into CFv1.
The text was updated successfully, but these errors were encountered: