Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conditionals to complaint detail body component for company resp… #467

Merged
merged 1 commit into from Oct 4, 2023

Conversation

wwhorton
Copy link
Contributor

…onse data

This PR adds some logic to only display the fields related to company response if that data is actually available. Otherwise, the heading and field isn't rendered.

Changes

  • adds conditionals to ComplaintDetailBody component template

Testing

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@contolini contolini mentioned this pull request Oct 2, 2023
9 tasks
@wwhorton wwhorton added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 0d65c7f Oct 4, 2023
2 checks passed
@wwhorton wwhorton deleted the ww-DATAP-42-empty-company-response branch October 4, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants