Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve complaint card link routing #479

Merged
merged 3 commits into from Nov 3, 2023
Merged

Improve complaint card link routing #479

merged 3 commits into from Nov 3, 2023

Conversation

contolini
Copy link
Member

The ellipses in complaint cards were using a vanilla anchor tag, causing them to ignore the app's router and lose the user's search status when returning to search results.

Addresses DATAP-1224

Changes

  • Replace anchor element with Link element.

Testing

  • yarn test should pass
  • Search for something.
  • Click the [...] on a complaint card with longer text.
  • Click the < Back to search results link on the dedicated complaint page. It should take you back to your search results instead of the CCDB homepage.

Screenshots

before after
before after

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

The ellipses in complaint cards were using a vanilla anchor tag, causing
them to ignore the app's router and lose the user's search status when
returning to search results.

Addresses DATAP-1224
@contolini contolini added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 55cc9d7 Nov 3, 2023
2 checks passed
@contolini contolini deleted the datap-1224 branch November 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants