Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update data product disclaimer #481

Merged
merged 3 commits into from Nov 7, 2023
Merged

Add/update data product disclaimer #481

merged 3 commits into from Nov 7, 2023

Conversation

contolini
Copy link
Member

Moves the data product disclaimer above the date filter and adds it to the chart as well.

Addresses DATAP-1225

Testing

  • yarn test passes
  • Text matches screenshot below.

Screenshots

before after
image Screenshot 2023-11-07 at 1 09 18 AM

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Moves the data product disclaimer above the date filter and adds it to
the chart as well.

Addresses DATAP-1225
Copy link
Contributor

@wwhorton wwhorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@contolini contolini added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit d4f0f0a Nov 7, 2023
2 checks passed
@contolini contolini deleted the datap-1225 branch November 7, 2023 18:43
@ielerol
Copy link
Member

ielerol commented Nov 7, 2023

@contolini when I set up my mockups I just used the "new text" referenced in the Jira issue, and didn't think to add in the link that's in production, but the info at the link is pretty important for actually seeing how the data has changed, so to be clear,

  • Both places the text appears should have the "learn more" link
  • There should be a period between "August 2023" and "Learn more".

Otherwise the screenshot looks good to me! Placement, sizing, etc looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants