Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a-error-message #492

Merged
merged 1 commit into from Mar 13, 2024
Merged

Remove a-error-message #492

merged 1 commit into from Mar 13, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 8, 2024 •
edited

This class is being removed in the DS in cfpb/design-system#1926

It appears styles are attached to this class here, but it doesn't appear to be used outside of the stylesheets.

Changes

  • Remove a-error-message CSS class.

flacoman91
flacoman91 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@flacoman91 flacoman91 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like this was being used anywhere.

I would have thought that this delete icon was supposed to be red, but 🤷

Screenshot 2024-03-08 at 4 41 24 PM

@anselmbradford
Copy link
Member Author

doesn't look like this was being used anywhere.

I would have thought that this delete icon was supposed to be red, but 🤷

Yeah that error message at the bottom of your screenshot is definitely missing styles, but regardless, it should be updated to a-form-alert https://cfpb.github.io/design-system/components/alerts#error-1

@anselmbradford anselmbradford added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 7cadd73 Mar 13, 2024
2 checks passed
@anselmbradford anselmbradford deleted the ans_remove_error branch March 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flacoman91 flacoman91 flacoman91 approved these changes

@wwhorton wwhorton Awaiting requested review from wwhorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anselmbradford @flacoman91