Drop the use of unicodecsv #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we can use Python3's csv module, we no longer need unicodecsv. Changes - Removes unicodecsv from requirements/libraries.txt - Imports the csv package instead of unicodecsv - Keep byte strings out of our code when possible - Fix tests that weren't running - Fixed the enforcement actions export script, which apparently stopped working when we introduced EnforcementActionPages in March. The script was written to harvest content from DocumentDetailPages. Satellite note Our satellite apps don't use unicodecsv anymore, but two of them, ccdb5-api and owning-a-home-api, still include it in setup.py install requirements. PRs are pending to remove the references. Thank you for your service, unicodecsv!
higs4281
requested review from
chosak,
cfarm,
Scotchester,
willbarton,
cwdavies and
schbetsy
willbarton
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can use Python3's csv module, we no longer need unicodecsv.
This removes a dependency originating from a Python2 weakness and also restores functionality
to the export-enforcement-actions script, which had stopped working.
Changes
when we introduced EnforcementActionPages in March. The script was written to
harvest content from DocumentDetailPages. Currently, the export produces a blank CSV.
Testing
Satellite note
Our satellite apps don't use unicodecsv anymore, but two of them,
ccdb5-api and owning-a-home-api, still include it as an install requirement in setup.py. PRs are pending to remove those references.
Thank you for your service, unicodecsv!