Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Director's Notebook category from Newsroom to Blog #5756

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

Scotchester
Copy link
Contributor

@Scotchester Scotchester commented Jun 2, 2020

Addresses https://GHE/CFGOV/platform/issues/3789

Changes

  • Move Director's Notebook category from Newsroom to Blog

Testing

  1. Pull branch
  2. Migrate
  3. Create a new blog post, giving it the "Director's notebook" category
  4. Ensure it displays properly on the blog listing page and that you can filter by that category

Notes

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool ➡️

@Scotchester Scotchester merged commit 87138af into master Jun 2, 2020
@Scotchester Scotchester deleted the move-directors-notebook branch June 2, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants