Moves MobileOnlyExpandable initialization out of MobileCarousel #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,8 @@ function init() { | |||
| return; | |||
| } | |||
|
|
|||
| var mobileCarousel = new MobileCarousel(); | |||
| var breakpointPx = 599; | |||
There was a problem hiding this comment.
This isn't being reused, might as well just include it as a straight value in the argument below right?
There was a problem hiding this comment.
I kept it as a variable to self-document it a bit better since it can be hard to tell what the straight-up number is setting. Could be a code comment too. Fixed in 9c28a42
|
👍 |
anselmbradford
force-pushed
the
move-mobile-only-expandable
branch
from
9c28a42
to
d8c0512
Compare
anselmbradford
added a commit
that referenced
this pull request
Jul 6, 2015
Moves MobileOnlyExpandable initialization out of MobileCarousel
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves MobileOnlyExpandable initialization out of MobileCarousel to provide better separation of responsibilities.
Changes
no-newrule errors.Testing
Review