Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDO phase1 -- update fields #62

Merged
merged 16 commits into from
Jul 7, 2020

Conversation

dvbalen
Copy link
Contributor

@dvbalen dvbalen commented Jun 30, 2020

Moved dataset_last_modified to content section
Add Open Data section & fields
Add FOIA fields
Added all outstanding fields to csv export
Fix bug in clean_select_multi() where commas in the content would break processing

@coveralls
Copy link

coveralls commented Jul 1, 2020

Coverage Status

Coverage increased (+0.2%) to 85.294% when pulling 103e509 on dvb-cfpb:cdo-phase1-update-fields into da07ed0 on cfpb:master.

Copy link
Collaborator

@tanderegg tanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @dvbalen thanks!

# select multis are contained in unicode strings that look like:
# u'{"blah blah","blah asdf",asdf}' ; u'{asdf,asdf}' ; u'asdf' (see also tests.py)
def clean_select_multi(s):
def clean_select_multi(raw_s):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tanderegg tanderegg merged commit 532739f into cfpb:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants