Fix dig import 2021 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderegg
approved these changes
May 12, 2021
ckanext/cfpb_extrafields/digutils.py
Outdated
| #except ImportError: # pragma: no cover | ||
| # # If the custom exception can't be imported, use a more generic exception | ||
| # # This happens when ckan is not installed locally, like when running unit tests on travis. | ||
| # Invalid = Exception |
There was a problem hiding this comment.
We can problem just remove this rather than comment it out, no?
ckanext/cfpb_extrafields/digutils.py
Outdated
| # Invalid = Exception | ||
|
|
||
| Invalid = Exception | ||
| NotFound = StopIteration |
There was a problem hiding this comment.
Should we just use the actual Exceptions at this point, rather than alias them?
|
@tanderegg please review and merge |
tanderegg
approved these changes
Jun 23, 2021
| @@ -31,12 +31,12 @@ def upload(self): | |||
| dig = request.POST["file"].file | |||
| group = request.POST["group"] | |||
| rec, errors = make_rec(dig) | |||
| if errors: | |||
| if False: #errors: | |||
There was a problem hiding this comment.
Could you add a comment explaining why we're skipping this, for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for Exceptions outside of CKAN validation
Pass DIG record to CKAN api for validation rather than error on missing field