Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
@anselmbradford
anselmbradford committed Jul 19, 2018
1 parent 061ed2d commit e21faea
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions paying_for_college/local_static/paying_for_college/disclosures/worksheet-dev.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ <h4>Building your cost comparison...</h4>
<p><label for="cb_books">Books &amp; Supplies</label><input tabindex="9994" type="text" value="" name="cb_books"></p>
<p><label for="cb_transportation">Transportation</label><input tabindex="9995" type="text" value="" name="cb_transportation"></p>
<p><label for="cb_otherexpenses">Other Expenses</label><input tabindex="9995" type="text" value="" name="cb_otherexpenses"></p>
<p class="navigatorlink"><a href="http://nces.ed.gov/collegenavigator/" target="_blank">Look up school information using College Navigator.</a></p>
<p class="navigatorlink"><a href="http://nces.ed.gov/collegenavigator/" target="_blank" rel="noopener noreferrer">Look up school information using College Navigator.</a></p>
<button class="button add_to_comparison start_comparing">Start Visualization</button>
<br>
<button class="add_average_public button preset">Set values to Average Public 4-Year University</button><br>
Expand Down Expand Up @@ -299,7 +299,7 @@ <h3 name="gap">$0</h3>
<p>You'll pay approx.</p>
<h3 class="colorize-red" name="loanmonthly">$0</h3>
<p>per month for 10 years to cover your Total Borrowing</p>
<p class="padtop"><a tabindex="10000" target="_blank" href="{% url pfc-learnmore %}#estimated_debt">Learn more</a></p>
<p class="padtop"><a tabindex="10000" href="{% url pfc-learnmore %}#estimated_debt" target="_blank" rel="noopener noreferrer">Learn more</a></p>
</div>
<div class="thisequals colright school-colorize">
<p>This equals</p>
Expand Down Expand Up @@ -331,7 +331,7 @@ <h5 name="riskdefault_text" class="medium">Medium</h5>
<div class="school-drawer-left">
<div class="data-financial">
<header class="data-header">
<h3 class="tooltip-info" tooltip="Financial Aid Award Offer: An offer from a college or career school that states the type and amount of financial aid, including federal grants and loans, that you will receive if you accept admission and register to take classes at that school.">First-Year Financial Aid Offer <a tabindex="10001" class="etip" target="_blank" href="{% url pfc-learnmore %}#financial_aid">Learn more</a></h3>
<h3 class="tooltip-info" tooltip="Financial Aid Award Offer: An offer from a college or career school that states the type and amount of financial aid, including federal grants and loans, that you will receive if you accept admission and register to take classes at that school.">First-Year Financial Aid Offer <a tabindex="10001" class="etip" href="{% url pfc-learnmore %}#financial_aid" target="_blank" rel="noopener noreferrer">Learn more</a></h3>
</header>

<div class="data-discount data group">
Expand Down Expand Up @@ -497,7 +497,7 @@ <h6 class="data-total" name="privatetotal">$0</h6>
<div class="school-drawer-right">
<div class="data-first-year data group">
<header class="data-header">
<h3>First-Year Costs <a tabindex="10015" class="etip" target="_blank" href="{% url pfc-learnmore %}#first_year">Learn more</a></h3>
<h3>First-Year Costs <a tabindex="10015" class="etip" href="{% url pfc-learnmore %}#first_year" target="_blank" rel="noopener noreferrer">Learn more</a></h3>
</header>
<h2><span name="firstyrcostattend">$0</span> total</h2>
<table cellpadding="0" cellspacing="0" border="0">
Expand Down Expand Up @@ -534,7 +534,7 @@ <h2><span name="firstyrcostattend">$0</span> total</h2>
</div><!-- end .data-first-year -->
<div class="data-school-risk data group">
<header class="data-header">
<h3>School Indicators <a tabindex="10020" class="etip" target="_blank" href="{% url pfc-learnmore %}#school_indicators">Learn more</a></h3>
<h3>School Indicators <a tabindex="10020" class="etip" href="{% url pfc-learnmore %}#school_indicators" target="_blank" rel="noopener noreferrer">Learn more</a></h3>
</header>
<table cellpadding="0" cellspacing="0" width="100%" border="0">
<tr>
Expand Down Expand Up @@ -634,7 +634,7 @@ <h4>Building your cost comparison...</h4>
<p><label for="cb_books" style="display:inline-block; text-align: right; font-size: 15px; width:200px; padding: 0px 10px;">Books &amp; Supplies</label><input tabindex="9994" type="text" value="" name="cb_books"></p>
<p><label for="cb_transportation" style="display:inline-block; text-align: right; font-size: 15px; width:200px; padding: 0px 10px;">Transportation</label><input tabindex="9995" type="text" value="" name="cb_transportation"></p>
<p><label for="cb_otherexpenses" style="display:inline-block; text-align: right; font-size: 15px; width:200px; padding: 0px 10px;">Other Expensses</label><input tabindex="9995" type="text" value="" name="cb_otherexpenses"></p>
<p class="navigatorlink"><a href="http://nces.ed.gov/collegenavigator/" target="_blank">Look up school information using College Navigator.</a></p>
<p class="navigatorlink"><a href="http://nces.ed.gov/collegenavigator/" target="_blank" rel="noopener noreferrer">Look up school information using College Navigator.</a></p>
<button class="add_to_comparison button" style="left: 25%; width: 50%;">Add to Comparison View</button>
<br>
<button class="add_average_public button" style="left: 25%; width: 50%; background-color: #999;">Set values to Average Public University</button><br>
Expand Down
2 changes: 1 addition & 1 deletion paying_for_college/templates/repay_student_debt.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ <h4 class="sample-text-header"><span class="cf-icon cf-icon-email"></span> Sampl
<div class="content-l_col content-l_col-1-4 tip-section">
<div class="tip_bar"></div><div class="tip_line"></div>
<h3>TIP</h3>
<p>Remember, if you’re having a problem with a student loan , you can submit a complaint <a href="http://www.consumerfinance.gov/complaint/" class="internal-link" target="_blank" rel="noopener noreferrer">online</a> or call us at (855) 411-2372.</p>
<p>Remember, if you’re having a problem with a student loan, you can submit a complaint <a href="http://www.consumerfinance.gov/complaint/" class="internal-link" target="_blank" rel="noopener noreferrer">online</a> or call us at (855) 411-2372.</p>
</div>
</div>
</section>
Expand Down
8 changes: 4 additions & 4 deletions src/disclosures/js/views/links-view.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var linksView = {
var $scorecardSchool = $( '<a>', {
'href': scorecardURL,
'target': '_blank',
'rel': 'noopener',
'rel': 'noopener noreferrer',
'class': this.$scorecardSchoolLink.attr( 'class' )
} )
.text( this.$scorecardSchoolLink.text() );
Expand All @@ -58,7 +58,7 @@ var linksView = {
var $gradLink = $( '<a>', {
'href': gradURL,
'target': '_blank',
'rel': 'noopener',
'rel': 'noopener noreferrer',
'class': this.$gradLinkText.attr( 'class' )
} )
.text( this.$gradLinkText.text() );
Expand All @@ -77,7 +77,7 @@ var linksView = {
var $defaultLink = $( '<a>', {
'href': defaultURL,
'target': '_blank',
'rel': 'noopener',
'rel': 'noopener noreferrer',
'class': this.$defaultLinkText.attr( 'class' )
} )
.text( this.$defaultLinkText.text() );
Expand All @@ -96,7 +96,7 @@ var linksView = {
var $schoolLink = $( '<a>', {
'href': schoolURL,
'target': '_blank',
'rel': 'noopener',
'rel': 'noopener noreferrer',
'class': this.$schoolLinkText.attr( 'class' )
} )
.text( this.$schoolLinkText.text() );
Expand Down

0 comments on commit e21faea

Please sign in to comment.