Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message posted when updating colleges #285

Merged
merged 3 commits into from
Oct 11, 2016
Merged

Improve message posted when updating colleges #285

merged 3 commits into from
Oct 11, 2016

Conversation

higs4281
Copy link
Member

@higs4281 higs4281 commented Oct 7, 2016 •
edited
Loading

This only affects a message a developer would seen when updating the
colleges database. It notes an important constant that needs to be
checked -- Salary year -- which is stored in the Django database.
Salary year differs from the 'Latest year' constant, because salary data
is always a couple years behind the rest of the data.

Changes

  • the update_colleges script, which is invoked by the update_via_api management command.
  • the collegedata fixture includes backported updates made in production

Review

  • @amymok
  • Project documentation and CHANGELOG updated.

@higs4281
Improve message posted when updating colleges
a4d078e 
This only affects a message a developer would seen when updating the
colleges database. It notes an important constant that needs to be
checked -- Salary year. It's a constant stored in the database, and it
differs from the 'Latest year' constant, because salary data is always a
couple years behind the rest of the data.
@higs4281
update changelog
5f6ffca
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5f6ffca on latest-salary-year into ab067bb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0eaa5d2 on latest-salary-year into ab067bb on master.

@amymok amymok merged commit a56555d into master Oct 11, 2016
@mistergone mistergone deleted the latest-salary-year branch August 18, 2017 20:14
@chosak chosak mentioned this pull request Aug 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amymok amymok amymok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@higs4281 @coveralls @amymok