Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #294

Merged
merged 3 commits into from
Jan 24, 2017
Merged

Feedback #294

merged 3 commits into from
Jan 24, 2017

Conversation

higs4281
Copy link
Member

This makes 2 improvements to PFC feedback:

  • fixes CSS static references
  • captures referrer to help with troubleshooting

Additions

  • new field and migration for Feedback model

Testing

  • When run inside cfgov-refresh or in standalone mode, paying-for-college2/understanding-your-financial-aid-offer/feedback/ should behave similarly to paying-for-college/compare-financial-aid-and-college-cost/feedback/

Checklist

  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c841ca2 on feedback into 2b71cf5 on master.

@higs4281 higs4281 mentioned this pull request Jan 24, 2017
Merged
sebworks
sebworks approved these changes Jan 24, 2017
View reviewed changes
Copy link

@sebworks sebworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should get some BEWD eyes on it.

willbarton
willbarton approved these changes Jan 24, 2017
View reviewed changes
Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it locally, but the code looks good.

@higs4281 higs4281 merged commit 8c9c710 into master Jan 24, 2017
@higs4281 higs4281 deleted the feedback branch January 24, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebworks sebworks sebworks approved these changes

@willbarton willbarton willbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@higs4281 @coveralls @sebworks @willbarton