Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified answer events to always fire irregardless of settlement status #306

Merged
merged 3 commits into from
Jun 1, 2017

Conversation

sebworks
Copy link

@sebworks sebworks commented Jun 1, 2017

Modified answer events to always fire irregardless of settlement status

Changes

  • Modified src/disclosures/js/views/question-view.js to always fire the answer event irregardless of settlement status.

Testing

  • Run 'gulp build`
  • Run the acceptance tests -- they should pass.
  • Everything should work as expected.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 905bc44 on fix_for_event_firing into fc9958a on master.

@sebworks sebworks merged commit 37e2c2b into master Jun 1, 2017
@sebworks sebworks deleted the fix_for_event_firing branch June 1, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants