Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.11 support #327

Merged
merged 6 commits into from
Sep 10, 2018
Merged

Django 1.11 support #327

merged 6 commits into from
Sep 10, 2018

Conversation

chosak
Copy link
Member

@chosak chosak commented Aug 15, 2018

This PR adds support to Django 1.11 to this project, which previously only supported Django 1.8.

Changes

  • Use tox to run unit tests instead of a pytest.sh script.
  • Use setup.py instead of requirements files, adding specific sections for testing and docs.

Testing

Todos

  • As discussed with @higs4281 and @ascott1, we might want to deprecate the Elasticsearch search part of this project as it isn't used in production.
  • Add documentation for testing/generating project documentation.
  • Better manual testing instructions.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@chosak chosak requested a review from schbetsy August 15, 2018 20:13
@coveralls
Copy link

coveralls commented Aug 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 8414a20 on chosak:django-1.11 into 6772512 on cfpb:master.

Copy link
Collaborator

@schbetsy schbetsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on @mistergone 's latest functional testing changes, and everything seems to be working. Tox passes, and the protractor tests mostly pass (with a few intermittent failures that I also see on django 1.8)

Just kidding, now #331 has more changes I'll need to test this with. Want to update this branch with latest master once #331 is merged?

@chosak chosak changed the title HOLD: Django 1.11 support Django 1.11 support Sep 10, 2018
@chosak chosak merged commit 27c818e into cfpb:master Sep 10, 2018
@chosak chosak deleted the django-1.11 branch September 10, 2018 16:11
@chosak chosak mentioned this pull request Sep 10, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants