Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update student-debt-calc and subdeps to address vulnerabilities #340

Merged
merged 3 commits into from
Mar 27, 2019

Conversation

Scotchester
Copy link

@Scotchester Scotchester commented Mar 26, 2019

This updates student-debt-calc and reinstalls other dependencies to get downstream security updates into package-lock.json, and makes a small update to the .snyk policy file.

I also changed npm run snyk to just be the snyk command, so that you can run things other than just snyk test. For example, I used npm run snyk wizard after making this change to automate the dependency updates.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 9ba4abb on snyking into 642bb7f on master.

@Scotchester Scotchester merged commit 8c2ca2d into master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants