-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py3 testing #343
Py3 testing #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew. Finally made a read-through. The changes all make sense to me and the tests pass for me! Heroic effort! A few comments follow.
'Programming Language :: Python :: 2.7', | ||
'Programming Language :: Python :: 3.6', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes me laugh.
@willbarton Thank you for the review, and for catching the python_2_unicode_compatible omissions! |
Code refactor for Python 3 and linting compliance.
I'm still fiddling with some csv tests and the coverage drop, but tThe beast can be observed.
[edited: imports combined]
It occurred to me that I do a variation of this little dance in a number of places, and it would be nice to just do it once:import sixif six.PY2:from unicodecsv import DictReaderelse:from csv import DictReader