Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 testing #343

Merged
merged 9 commits into from
May 14, 2019
Merged

Py3 testing #343

merged 9 commits into from
May 14, 2019

Conversation

higs4281
Copy link
Member

@higs4281 higs4281 commented Apr 3, 2019

Code refactor for Python 3 and linting compliance.
I'm still fiddling with some csv tests and the coverage drop, but t
The beast can be observed.

[edited: imports combined]
It occurred to me that I do a variation of this little dance in a number of places, and it would be nice to just do it once:
import six
if six.PY2:
from unicodecsv import DictReader
else:
from csv import DictReader

@coveralls
Copy link

coveralls commented Apr 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling f30e32f on py3-testing into 09eab0c on master.

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew. Finally made a read-through. The changes all make sense to me and the tests pass for me! Heroic effort! A few comments follow.

paying_for_college/disclosures/scripts/nat_stats.py Outdated Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/models.py Show resolved Hide resolved
paying_for_college/tests/test_commands.py Show resolved Hide resolved
paying_for_college/views.py Outdated Show resolved Hide resolved
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.6',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me laugh.

@higs4281
Copy link
Member Author

higs4281 commented May 9, 2019

@willbarton Thank you for the review, and for catching the python_2_unicode_compatible omissions!

@higs4281 higs4281 merged commit 277ef0f into master May 14, 2019
@higs4281 higs4281 deleted the py3-testing branch May 14, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants