Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the capturing of school closures. #351

Merged
merged 1 commit into from
May 31, 2019
Merged

Fix the capturing of school closures. #351

merged 1 commit into from
May 31, 2019

Conversation

higs4281
Copy link
Member

We weren't saving the College Scorecard API's school.operating value properly,
because the delivered values are 1 and 0, not True or False.

@higs4281
Fix the capturing of school closures.
2f952bb 
We were'nt saving the College Scorecard API's `school.operating` value properly,
because the delivered values are 1 and 0, not True or False.
@higs4281 higs4281 requested a review from mistergone May 31, 2019 06:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2f952bb on fix-closed-school-values into 214adf0 on master.

mistergone
mistergone approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@mistergone mistergone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@higs4281 higs4281 merged commit ab11645 into master May 31, 2019
@higs4281 higs4281 deleted the fix-closed-school-values branch May 31, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistergone mistergone mistergone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@higs4281 @coveralls @mistergone