Skip to content
This repository has been archived by the owner on Jun 13, 2020. It is now read-only.

Modifying api endpoints in js and html #16

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Conversation

sebworks
Copy link
Contributor

@sebworks sebworks commented Mar 8, 2017

Modifying api endpoints in js and html

Changes

  • Modified complaintdatabase/templates/landing-page.html to change the api endpoint.
  • Modified src/static/js/complaint-urls.js to change the api endpoint.

Testing

  • run gulp build
  • run npm test
  • Visit http://localhost:8000/data-research/consumer-complaints/#download-the-data and inspect the download button in the console.
  • The button href should point to https://data.consumerfinance.gov/api/views/s6ew-h6mp/rows.csv?accessType=DOWNLOAD.
  • Select different radio options within CHOOSE FROM THESE PRODUCTS AND SERVICES. Verify the download button href changes as you select the different options.

Review

Preview this PR without the whitespace changes

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@sebworks sebworks merged commit 55c2870 into master Mar 9, 2017
@sebworks sebworks deleted the fix_for_api_endpoints branch March 9, 2017 13:35
Scotchester pushed a commit that referenced this pull request Jun 12, 2020
Modifying api endpoints in js and html
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants