Merge pull request #8478 from cfpb/fix-authors

Fix index bug in author sorting method and display bug in item introduction

cfgov/v1/jinja2/v1/includes/organisms/item-introduction.html

@@ -14,7 +14,7 @@
    value.show_category:    Whether to show the category or not.
    value.heading:          Heading text.
    value.paragraph.source: Body introduction text.
-   value.authors:          Array of author names and associated URLs.
+   value.authors:          Array of author names
 
    value.date:             A datetime for the post.
    value.has_social:       Whether to show the share icons or not.
@@ -59,7 +59,7 @@ <h1>{{ value.heading | safe }}</h1>
             <span class="byline">
             {%- for author in page.get_authors() -%}
                 {% if loop.first %}By {% elif loop.last %}and {% endif %}
-                {{ author.name }}
+                {{ author }}
                 {%- if loop.length > 2 and loop.index < loop.length %}, {% endif %}
             {% endfor %}
                 &ndash;

cfgov/v1/models/base.py

@@ -198,7 +198,7 @@ def get_authors(self):
 
         def sorting(name):
             parts = name.rsplit(" ", 1)
-            return parts[1], parts[0]
+            return parts[0] if len(parts) == 1 else parts[1], parts[0]
 
         return sorted(
             [author.name for author in self.authors.all()], key=sorting

cfgov/v1/tests/models/test_author_names.py

@@ -9,6 +9,11 @@ def check_authors(self, authors, expected):
         page.authors.add(*authors)
         self.assertEqual(page.get_authors(), expected)
 
+    def test_author_names_with_no_space(self):
+        self.check_authors(
+            ["Wyatt Pearsall", "CFPB"], ["CFPB", "Wyatt Pearsall"]
+        )
+
     def test_alphabetize_authors_by_last_name(self):
         self.check_authors(
             ["Ross Karchner", "Richa Agarwal", "Andy Chosak", "Will Barton"],