Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--sauce CLI flag is broken #2324

Closed
anselmbradford opened this issue Aug 19, 2016 · 2 comments
Closed

--sauce CLI flag is broken #2324

anselmbradford opened this issue Aug 19, 2016 · 2 comments
Assignees

Comments

@anselmbradford
Copy link
Member

At some point the Sauce Connect --sauce flag broke and doesn't work anymore. Fixing this issue should really address #885 as well.

Also, #887 and #886 are Sauce issues.

Current behavior

  • Tests run with and without the --sauce flag do not run on Sauce, even with the SAUCE_USERNAME and SAUCE_ACCESS_KEY credentials set in .env.

Expected behavior

  • Tests run with the --sauce=true flag set should attempt to run tests through a local running Sauce Connect tunnel. (In the past the behavior was also make this the default, so no --sauce flag at all would be equivalent to its value being true.)

Steps to replicate behavior

  1. Set SAUCE_USERNAME and SAUCE_ACCESS_KEY credentials in .env and uncomment SAUCE_SELENIUM_URL.
  2. Run gulp test:acceptance --sauce=true and note that there are no errors around Sauce connect not running and the tests run locally as if gulp test:acceptance --sauce=false were set.
@sebworks sebworks self-assigned this Mar 31, 2017
@sebworks
Copy link
Contributor

Fixed in #3040

@sebworks
Copy link
Contributor

(In the past the behavior was also make this the default, so no --sauce flag at all would be equivalent to its value being true.)

I've modified the code to not default to Sauce because it does require setting .env variables and runs externally.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants