Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the naming conventions for the browser list config #3597

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

jimmynotjim
Copy link
Contributor

@jimmynotjim jimmynotjim commented Nov 21, 2017

Steven pointed out that the constants should be formatted in caps with
underscore separators.

Testing

  1. Run gulp clean
  2. Run gulp build
  3. Run gulp scripts:ondemand

Everything should build and none of the site styles or interactions should differ in any browsers.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated
  • Reviewers requested with the Reviewer tool ➡️

Steven pointed out that the constants should be formatted in caps with
underscore separators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants