Fix job listings with multiple USAJobs links #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for job listings that have multiple USAJobs links in them. With Python 3's stricter comparisons, attempting to order the `USAJobsApplicationLink` objects using `applicant_type` was failing with `ApplicantType` not supporting `<` operations. This fix adds `__gt__` and `__lt__` to `ApplicantType` to support `>` and `<` operations. Generally this appears to come from django-modelcluster and behavior that differs from the Django expectation, possibly related to wagtail/django-modelcluster#45.
willbarton
requested review from
higs4281,
Scotchester,
schbetsy and
cwdavies
Scotchester
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for job listings that have multiple USAJobs links in them. With Python 3's stricter comparisons, attempting to order the
USAJobsApplicationLinkobjects usingapplicant_typewas failing withApplicantTypenot supporting<operations.This fix adds
__gt__and__lt__toApplicantTypeto support>and<operations.Generally this appears to come from django-modelcluster and behavior that differs from the Django expectation, possibly related to wagtail/django-modelcluster#45.
Testing
Checklist