Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few modifications to support Django 2.2:
request._post_parse_error
, used in our logging alert handler, was removed in Django 2.1. This PR simply removes the check for it, as we have a genericException
handler for formatting post data.None
is no longer encoded in post data byRequestFactory
, and values that would beNone
should. instead be omitted. This PR makes a modification to the feedback tests wherereferrer
andis_helpful
were being passed asNone
if no other value was given.schema_json
must have a JSON-parsable value. In the jobmanager tests we perform a post to the Wagtail admin andschema_json
was not defined. This PR defines it with a blank string.call_command
. In the feedback admin export, we usecall_command
to call theexport_feedback
management command, and were previously providingpages
as a keyword argument. This PR explodespages
as positional arguments instead.There is one final category of test failures we're currently seeing, with
is_safe_url
. @cwdavies has addressed these in #5680.unittest-future
will fail here until #5680 is merged and this PR is rebased.Testing
1.
tox -e unittest-future
Checklist