Fix Mattermost alert webhook call #5700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mattermost seems to have gotten more particular about the
Content-Type
header of incoming webhooks in the upgrade from 5.18 to 5.22.We were seeing errors of this kind:
This change switches our alert webhook's
requests.post
call from using Requests'data
param to using itsjson
param, which sets theContent-Type
toapplication/json
, as Mattermost now requires.See: https://requests.readthedocs.io/en/master/user/quickstart/#more-complicated-post-requests
Changes
requests.post
call fromdata
tojson
Testing
In your cfgov-refresh virtualenv, open the Python console and walk through the following:
Notes
Checklist