Filterable list control: Convert date inputs into datepicker fields #6009
Conversation
|
|
||
| /* TODO: Merge this into the regex checks. | ||
| This converts numbers from any other format to MM/DD/YYYY */ | ||
| if ( !Number.isNaN( field.valueAsNumber ) ) { |
There was a problem hiding this comment.
IE11 doesn't support Number.isNaN. You can use isNaN though.
cfgov/v1/util/date_filter.py
Outdated
|
|
||
| # For more information on date formatting, see the python documentation here: | ||
| # https://docs.python.org/2/library/datetime.html#strftime-and-strptime-behavior | ||
|
|
||
| full_date_patterns = ( | ||
| '%m/%d/%Y', # 10/25/2016, 9/1/2016 | ||
| '%m-%d-%Y', # 10-25-2016, 9-1-2016 | ||
| '%Y-%m-%d', # 2016-10-25, 2016-9-1 |
There was a problem hiding this comment.
%m and %d are zero-padded so it'd be cool if you could update all these comments accordingly (2016-09-01, 09-01-2016, etc.) See https://docs.python.org/2/library/datetime.html#strftime-and-strptime-behavior.
|
@anselmbradford Hey, just wanted to let you know there is an associated cypress test for filterable lists. Looks like this change breaks one of the tests (unsurprisingly around the date) |
|
Thanks @alexm118 ! I updated the associated test. This brings up the question of how does Cyprus fit into our code checks? Is the idea it will run in GitHub actions in PRs like this one (if it's possible to run headless), or will it run with |
|
@anselmbradford Currently, the cypress tests run in headless mode inside our jenkins server. Potentially once we have github hooks setup it may be possible for us to do something with Github Actions (we could possibly do this without jenkins, I just haven't dug into the potential work it would take to spin up the docker stack via Github Actions). I put some documentation in place for how Cypress is currently setup to run, there are a couple options basically one that leverages docker and another that allows you to run it via yarn. I find that running via yarn is helpful when modifying/creating tests and docker is easier to run when you just want to validate the tests will pass but YMMV. |
|
|
Most modern browsers have built in datepickers. Let's use them!
Changes
datein the filterable list control.How to test this PR
Screenshots
Chrome
Firefox
Probably Opera
Safari 馃槥
Edge
iOS
