Prevent duplicate highlights in mega menu #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
force-pushed
the
fix/mega-menu-single-highlight
branch
from
8039b25
to
42cdc26
Compare
schbetsy
reviewed
Sep 18, 2020
| }, | ||
| ]) | ||
|
|
||
| def test_conversion_output_selection_ignores_query_string(self): |
There was a problem hiding this comment.
What are your thoughts about adding a test for the specific behavior that's added in this PR? I might be wrong, but this test seems more like #6012
There was a problem hiding this comment.
Thanks, you're totally right. I'll add one.
There was a problem hiding this comment.
@schbetsy I've added a test for this behavior; would you mind re-reviewing when you get a chance?
schbetsy
approved these changes
Sep 21, 2020
chosak
force-pushed
the
fix/mega-menu-single-highlight
branch
from
26cfac3
to
cc0f1c7
Compare
chosak
force-pushed
the
fix/mega-menu-single-highlight
branch
from
cc0f1c7
to
ce76a22
Compare
This change modifies the existing mega menu logic to prevent duplicate highlights in the mega menu, for cases where a menu link is duplicated between submenus. The code now ensures that only at most one submenu and at most one link gets highlighted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the existing mega menu logic to prevent duplicate highlights in the mega menu, for cases where a menu link is duplicated between submenus.
The code now ensures that only at most one submenu and at most one link gets highlighted.
How to test this PR
Edit the mega menu to duplicate a link between two submenus. Internally, see UCP PR deployment for this running live with an example.
Checklist