Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask: change date label text #6037

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Ask: change date label text #6037

merged 4 commits into from
Sep 28, 2020

Conversation

virginiacc
Copy link
Contributor

@virginiacc virginiacc commented Sep 25, 2020 •
edited
Loading

Change the label for the date on Ask answer pages.

Additions

  • last reviewed in translations file

Changes

  • Change date label text from updated to last reviewed on Ask answer pages

How to test this PR

  1. Check out branch
  2. Navigate to an Ask answer page and verify that date label is now last reviewed
  3. Click link to Spanish version of page and verify that date label is now revisado

Screenshots

English page

Screen Shot 2020-09-24 at 9 45 54 PM

Spanish page

Screen Shot 2020-09-24 at 9 46 06 PM

@virginiacc virginiacc changed the title Ask: change date label text (WIP) Ask: change date label text Sep 25, 2020
@virginiacc virginiacc changed the title (WIP) Ask: change date label text Ask: change date label text Sep 28, 2020
@virginiacc
Copy link
Contributor Author

Thanks for reviewing, @higs4281!

@virginiacc virginiacc merged commit 6b995fb into main Sep 28, 2020
@virginiacc virginiacc deleted the ask-last-reviewed branch September 28, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@higs4281 higs4281 higs4281 approved these changes

@Scotchester Scotchester Scotchester approved these changes

@mistergone mistergone Awaiting requested review from mistergone

@keelerr keelerr Awaiting requested review from keelerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@virginiacc @higs4281 @Scotchester