Add Elasticsearch 7 support to paying_for_college search behind a flag #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwdavies
requested review from
willbarton,
alexm118,
higs4281 and
Scotchester
higs4281
reviewed
Oct 15, 2020
The current use of `os.path.join` in base settings results in a malformed host
value (below), in which the port signifier ':' is surrounded by slashes:
```
ELASTICSEARCH_DSL: {'default': {'hosts': 'http://localhost/:/9200'}}
```
Elasticsearch then reads the ':' as an index name and raises a naming error:
```
"Invalid index name [:], must not contain ':'")
```
higs4281
requested changes
Oct 26, 2020
higs4281
reviewed
Oct 27, 2020
higs4281
reviewed
Oct 27, 2020
higs4281
reviewed
Oct 27, 2020
…y uses an autocomplete search box
higs4281
reviewed
Oct 27, 2020
chosak
reviewed
Oct 27, 2020
I recommend having a test to confirm a school that has closed is excluded. I hope that I have fixed autocomplete to enable searches by school_id and nickname. |
All the schools in test_fixture.json are |
higs4281
requested changes
Oct 28, 2020
higs4281
reviewed
Oct 28, 2020
…oolDocument Removed str from nicknames in school_autocomplete because list-as-string is not friendly in the API response Modified autocomplete to return the default top 10 hits instead of the entire response set
higs4281
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Places ES7 paying_for_college search functionality behind a flag
Additions
test_search.pywithSchoolSearchTestclassUpdates
test_school_searchfromtest_views.pyintotest_search.pyHow to test this PR
ELASTICSEARCH_DSL_PFCflagcfgov/manage.py search_index --rebuild -f --parallelhttps://cfgov-pr-6075.demo.cfpb.gov/paying-for-college2/understanding-your-financial-aid-offer/api/search-schools.json?q=Kansas
Screenshots
Notes and todos
Checklist
/docsfolder) – for basic, close-to-the-code docs on working with this repo