Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump retirement to 0.15.1 #6081

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Bump retirement to 0.15.1 #6081

merged 1 commit into from
Oct 19, 2020

Conversation

niqjohnson
Copy link
Member

We've fixed a couple of bugs in the retrirement app: preventing the retirement translations from leaking into other parts of the site and getting the Spanish mega-menu showing on the Spanish about page. See GHE/CFGOV/platform/issues/3912 for more details.


Changes

How to test this PR

  1. Go to the the retirement tool's Spanish about page, /consumer-tools/retirement/before-you-claim/about/es/. Verify that the Spanish mega-menu is showing on that page.
  2. Fill out the Spanish financial wellbeing survey, /consumer-tools/financial-well-being/es/, and get your results. Verify that the "Edad" button is correctly translated on the results page.

Screenshots

Page 0.15.0 (production) 0.15.1 (this PR)
Retirement Spanish about retirement-prod retirement-fixed
FWB Spanish results page fwb-prod fwb-fixed

Notes and todos

  • Some English footer content is still showing up on the Spanish retirement pages, but that seems to be a larger issue that I think we should handle in a separate PR.

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets

We've fixed a couple of bugs in the retrirement app: preventing the retirement
translations from leaking into other parts of the site and getting the Spanish
mega-menu showing on the Spanish about page.
@niqjohnson niqjohnson merged commit f3ee138 into main Oct 19, 2020
@niqjohnson niqjohnson deleted the bump-retirement branch October 19, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants