Add proprietarily-licensed font files #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarton
requested review from
wpears,
baruva,
jslay-excella and
Colin-Seifer
|
I wonder if we should just add the fonts we use. I think we put them all in the private repo for reference if needed, but doesn't seem like we need them all here (and can always grab them from the private repo, if needed). The files we use are these two for regular: https://github.com/cfpb/design-system/blob/main/packages/cfpb-typography/src/licensed-fonts.less#L52-L53 And these two for medium: https://github.com/cfpb/design-system/blob/main/packages/cfpb-typography/src/licensed-fonts.less#L62-L63 |
I endorse this! |
|
@anselmbradford @wpears alrighty, I'll remove everything that's not those files! |
This changes adds our proprietary font files to this repository, with a note in the README regarding their licensing.
This change removes the font faking we had in our frontend build for CI usage. The only difference between “production” and “ci” in the frontend build was to fake our proprietary font files.
wpears
approved these changes
Apr 26, 2022
willbarton
added a commit
that referenced
this pull request
Apr 27, 2022
In #7025 added our private font files to this repository, I missed this part of the build script that would add extra arguments for our webfonts path.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds our proprietary font files to this repository, with a note in the README regarding their licensing.
This change also removes the "ci" frontend build target which was only used for faking these font files in public CI.
Checklist