Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pin newrelic dependency #8150

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Don't pin newrelic dependency #8150

merged 7 commits into from
Mar 15, 2024

Conversation

anselmbradford
Copy link
Member

The newrelic dependency is way out of date, @OrlandoSoto suggests we don't pin it to always pull in the latest.

Changes

  • Don't pin newrelic dependency

willbarton
willbarton approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only hesitation I have is if, let's say, we're still on Python 3.8 after it EOLs and New Relic's Python library drops support for 3.8, it could block deploys. But we shouldn't let that happen anyway.

@anselmbradford anselmbradford added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 20cca01 Mar 15, 2024
13 checks passed
@anselmbradford anselmbradford deleted the ans_dont_pin_nr branch March 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarton willbarton willbarton approved these changes

@chosak chosak Awaiting requested review from chosak

@OrlandoSoto OrlandoSoto Awaiting requested review from OrlandoSoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anselmbradford @willbarton