TCCP: Feature flag logic to support beta testing #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
force-pushed
the
tccp/feature-flags
branch
from
855a3cd
to
1290515
Compare
Currently the TCCP feature flag logic prohibits it from running in either beta or production. Soon we want to be able to test on beta. This change modifies the feature flag logic such that TCCP is always available locally or on our internal DEV4 testing server. Deploying it in other environments will require manually enabling it via the Wagtail UI.
chosak
force-pushed
the
tccp/feature-flags
branch
from
1290515
to
a1ba4a3
Compare
contolini
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the TCCP feature flag logic prohibits it from running in either beta or production. Soon we want to be able to test on beta.
This change modifies the feature flag logic such that TCCP is always available locally or on our internal DEV4 testing server. Deploying it in other environments will require manually enabling it via the Wagtail UI.
How to test this PR
Running locally (
./runserver.sh) TCCP should work properly.Running locally as if you were in another environment (
DEPLOY_ENVIRONMENT=beta ./runserver.sh) should result in a 404 for TCCP pages, unless you explicitly enable it by going to http://localhost:8000/admin/flags/TCCP/.Checklist