Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card details cleanup #8181

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Card details cleanup #8181

merged 2 commits into from
Mar 4, 2024

Conversation

niqjohnson
Copy link
Member

Clean up card details Jinja to match the other TCCP templates and pulls the inline CSS into the TCCP app's stylesheet.

  • You might have to show whitespace changes in the diff view to see some of the cleanup
  • I tried to match the Jinja style in the other TCCP templates as best I could, but happy to keep tweaking so everything is consistent
  • @contolini, do you think the .m-list__card-details variant is the right way to style the card details definition list? I don't have any strong opinions, happy to change to something else.

Changes

  • Jinja formatting cleanup
  • Moved inline CSS to TCCP app stylesheet

How to test this PR

  1. Poke around a few cards' details pages. Everything should match what's currently on DEV4.

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think the .m-list__card-details variant is the right way to style the card details definition list? I don't have any strong opinions, happy to change to something else.

I dig it! Our app is a little confusing because card refers to credit cards and not the design pattern but our styles are scoped to our app so I think it's fine.

@niqjohnson niqjohnson added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 928f742 Mar 4, 2024
17 checks passed
@niqjohnson niqjohnson deleted the card-details-cleanup branch March 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants