Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ask-cfpb and job listing assets to apps #8399

Merged
merged 5 commits into from May 10, 2024
Merged

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented May 8, 2024

Ask has some JS/CSS that is spread out across our global styles, but really are Ask-specific. This moves those assets to a new ask-cfpb app.

This PR also moves the job listing assets to a careers app, excluding the one on-demand CSS file.

Changes

  • Move Ask-cfpb assets to an app.
  • Move careers job listing assets to an app.

How to test this PR

Ask landing - search should show autocomplete
http://localhost:8000/ask-cfpb/

Ask landing Spanish - search show autocomplete
http://localhost:8000/es/obtener-respuestas/

Ask search - search should not show autocomplete
http://localhost:8000/ask-cfpb/search

Ask answers - search does not have an autocomplete
https://www.consumerfinance.gov/consumer-tools/auto-loans/answers/

Summaries:

Ask detail - resize to mobile to see summary component
http://localhost:8000/ask-cfpb/how-can-i-tell-if-a-friend-neighbor-or-family-member-is-a-victim-of-financial-exploitation-en-1933/

Job listing - click on a current job posting and resize to mobile to see summary component
http://localhost:8000/about-us/careers/current-openings/

Prepaid agreements - minimal summary should be present
http://localhost:8000/data-research/prepaid-accounts/search-agreements/detail/48439/

Notes and todos

  • In Ask, the summary.js is only used on Ask details view, but for simplicity the JS is delivered to all ask pages.

@anselmbradford anselmbradford force-pushed the ans_ask_app branch 3 times, most recently from fa776da to 1cb18fe Compare May 9, 2024 16:20
@anselmbradford
Copy link
Member Author

partially-styled-link work spun out to #8402

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Everything works as advertised

@anselmbradford anselmbradford added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 987b5e1 May 10, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_ask_app branch May 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants