Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCCP: Tidy up detail page "other fees" Jinja #8405

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented May 10, 2024

This commit tidies up the Jinja logic for "other fees" in the card details page. It has no impact on the visible rendering of the content.

How to test this PR

Running a local server with the latest dataset, here are some pages to check:

Screenshots

No fees 1 fee 5 fees
image image image

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

This commit tidies up the Jinja logic for "other fees" in the card
details page. It has no impact on the visible rendering of the content.
@chosak chosak requested a review from niqjohnson May 10, 2024 16:16
Copy link
Member

@niqjohnson niqjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't actually run cf.gov locally to test, but code-wise this looks great. Super slick way to get around the inconsistently named other fee fields. Looks good to merge to me, I can always check when it gets to Beta.

@chosak chosak added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 32c6cf1 May 13, 2024
12 checks passed
@chosak chosak deleted the tccp/other-fee-tidying branch May 13, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants