TCCP: Consolidate card rating markup #8413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
commented
May 13, 2024
chosak
force-pushed
the
tccp/unify-card-rating
branch
from
516aaa7
to
1e03f9d
Compare
chosak
commented
May 13, 2024
This commit consolidates several different ways that we markup TCCP card ratings (the colored icon next to a description like "Pay less interest"). The new apr_rating macro can be used to render just this bit; various places on the card list and details view now use this macro. Styles have been reworked to support this new approach. To test, run a local server and visit pages like: - http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/ - http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/vinton-county-national-bank-consumer-credit-card/ Check sizing on mobile and desktop widths.
chosak
force-pushed
the
tccp/unify-card-rating
branch
from
1e03f9d
to
44cef70
Compare
* Add APR rating descriptive text for assistive technologies, wrap APR ratings in <dl> * Replace dl spacing overrides with footer margin
contolini
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consolidates several different ways that we markup TCCP card ratings (the colored icon next to a description like "Pay less interest").
The new apr_rating macro can be used to render just this bit; various places on the card list and details view now use this macro.
Styles have been reworked to support this new approach.
How to test this PR
To test, run a local server and visit pages like:
Check sizing on mobile and desktop widths.
Screenshots
Display should be unchanged from before:
Notes and todos
An unrelated obsolete comment has also been removed from the detail page template; see internal https://github.local/Design-Development/Design-Thinking-and-User-Research/issues/306#issuecomment-354312 for context.
Checklist