TCCP: Make institution names uppercase in results #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we list cards on the TCCP results view, we want the institution names to be uppercase. Previously we were counting on their names being uppercase in the source dataset, but the most recent dataset have some that are mixed case. To test, sort alphabetically using the latest dataset: http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/?credit_tier=Credit%20scores%20from%20620%20to%20719&location=&ordering=product_name
caheberer
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we list cards on the TCCP results view, we want the institution names to be uppercase. Previously we were counting on their names being uppercase in the source dataset, but the most recent dataset have some that are mixed case.
How to test this PR
To test, sort alphabetically using the latest dataset:
http://localhost:8000/consumer-tools/credit-cards/explore-cards/cards/?credit_tier=Credit%20scores%20from%20620%20to%20719&location=&ordering=product_name
Screenshots
Checklist