Check in smoketest urls #8433
Merged
Check in smoketest urls #8433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the changes in cfgov/cfgov/urls.py? Are those unrelated? |
Those are redirects to redirects that I noticed when running the script locally. Just shortening the redirect chain here. |
willbarton
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8429 didn't take because, currently, the true list of urls to test lives in S3. I believe the logic here was that it was easier to update and/or would hook into a dynamically updating list.
These things don't actually happen, so I believe it's actually better practice to switch the fallback url_list to the actual list. This makes the script more obvious in behavior (it was already obvious if I actually read the code instead of just noticing the list... but now it's REALLY obvious) and feels a little more deliberate/less magic.