-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize jump links #8454
Merged
Merged
Standardize jump links #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
commented
Jun 1, 2024
@@ -120,6 +120,10 @@ | |||
top: 0; | |||
align-self: start; | |||
|
|||
// This puts the secondary nav behind the mega menu hamburger menu, | |||
// but above other things on the page. | |||
z-index: 9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@contolini is this change for FIG sticky nav OK?
2a1e467
to
2b5be64
Compare
wpears
requested changes
Jun 4, 2024
cfgov/teachers_digital_platform/jinja2/teachers_digital_platform/activity_page.html
Show resolved
Hide resolved
wpears
approved these changes
Jun 4, 2024
42bf55b
to
132ab68
Compare
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in design-system jump link updates from:
cfpb/design-system#1987
cfpb/design-system#1988
cfpb/design-system#1989
cfpb/design-system#1990
cfpb/design-system#1991
Changes
m-list__link
toa-link a-link--jump
.How to test this PR
a-link--jump
in the source).KBYO
http://localhost:8000/know-before-you-owe/
http://localhost:8000/know-before-you-owe/compare/
http://localhost:8000/know-before-you-owe/timeline/
Careers - should not have a broken subtext
http://localhost:8000/about-us/careers/
http://localhost:8000/about-us/careers/supervisory-investigator-24-cfpb-139-p24-cfpb-138-mp/
http://localhost:8000/about-us/careers/application-process/
Financial Well-being
http://localhost:8000/consumer-tools/financial-well-being/
http://localhost:8000/consumer-tools/financial-well-being/about/
http://localhost:8000/consumer-tools/financial-well-being/results/
Ask CFPB
http://localhost:8000/ask-cfpb/
http://localhost:8000/ask-cfpb/do-buy-now-pay-later-bnpl-loans-have-fees-en-2118/
D&I
http://localhost:8000/about-us/diversity-and-inclusion/voluntary-assessment-onboarding-form/
http://localhost:8000/about-us/diversity-and-inclusion/voluntary-assessment-onboarding-form/privacy-act-statement/
TDP
http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/bouncing-ball-money-choices/
Retirement
http://localhost:8000/es/herramientas-del-consumidor/jubilacion/antes-de-solicitar/
OAH/BAH Rate Explorer
http://localhost:8000/owning-a-home/explore-rates/
FAHC
http://localhost:8000/find-a-housing-counselor/
ROUT
http://localhost:8000/rural-or-underserved-tool/
iRegs
http://localhost:8000/rules-policy/regulations/1002/2023-04-19/interp-1/
FIG
http://localhost:8000/data-research/small-business-lending/filing-instructions-guide/2024-guide/
Credit Card agreements database related links - sidebar related links should NOT be jump link at mobile
http://localhost:8000/credit-cards/agreements/issuer/1st-advantage-federal-credit-union/
Info Unit Groups
http://localhost:8000/about-us/
Featured Content
http://localhost:8000/consumer-tools/credit-reports-and-scores/consumer-reporting-companies/
Notification
http://localhost:8000/arbitration-rule/
Text Introduction
http://localhost:8000/administrative-adjudication-proceedings/administrative-adjudication-docket/
Homepage - footer links should be unchanged.
http://localhost:8000/
Notes and todos
The new behavior of jump links vertically centers the external link icon after the text, so if the link is very long, it'll end up on the right-hand side. We should probably encourage shorter links if that's an issue. I think it improves cases like this though:
Before:
![Screenshot 2024-05-31 at 5 25 29 PM](https://private-user-images.githubusercontent.com/704760/335758465-d0474f1e-789a-4cdc-8657-a5e58b04b173.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzODc1NDQsIm5iZiI6MTcyMDM4NzI0NCwicGF0aCI6Ii83MDQ3NjAvMzM1NzU4NDY1LWQwNDc0ZjFlLTc4OWEtNGNkYy04NjU3LWE1ZTU4YjA0YjE3My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwN1QyMTIwNDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZDc0MGY5NjFiZDM2ZmUzOThmMjVmMDQxZjIzMTE0NDQ3MDM5YzA3ZGUwM2JlMzE0ODQ5ODZlZDk0NjZiYTEwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.-ceuo19LkzVOKy4o0zWtS8BhVnZJ8PnTlBF9hiyx6_4)
After:
![Screenshot 2024-05-31 at 5 25 38 PM](https://private-user-images.githubusercontent.com/704760/335758526-4e83efa3-6e5f-4054-9f77-c03d54945586.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzODc1NDQsIm5iZiI6MTcyMDM4NzI0NCwicGF0aCI6Ii83MDQ3NjAvMzM1NzU4NTI2LTRlODNlZmEzLTZlNWYtNDA1NC05Zjc3LWMwM2Q1NDk0NTU4Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwN1QyMTIwNDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNjBkZDJhNDFiNDYzM2VkYzVmOWFiYTI3MTM5NTQ2ZjQ4YTg1NjM4ZTE5MThlMWRhNGFjMWQ4NGZiYTkxYWI0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._qVD7a-IKIftt7woNC_RFEz4AXxDGUgnMuAO4--lTuU)