Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize jump links #8454

Merged
merged 27 commits into from
Jun 4, 2024
Merged

Standardize jump links #8454

merged 27 commits into from
Jun 4, 2024

Conversation

anselmbradford
Copy link
Member

Brings in design-system jump link updates from:

cfpb/design-system#1987
cfpb/design-system#1988
cfpb/design-system#1989
cfpb/design-system#1990
cfpb/design-system#1991

Changes

  • Deprecate m-list__link to a-link a-link--jump.
  • Fix issue where jump links in a stack would not highlight the top border on hover.

How to test this PR

  1. Example pages are below. The majority should have jump links (search for a-link--jump in the source).

KBYO
http://localhost:8000/know-before-you-owe/
http://localhost:8000/know-before-you-owe/compare/
http://localhost:8000/know-before-you-owe/timeline/

Careers - should not have a broken subtext
http://localhost:8000/about-us/careers/
http://localhost:8000/about-us/careers/supervisory-investigator-24-cfpb-139-p24-cfpb-138-mp/
http://localhost:8000/about-us/careers/application-process/

Financial Well-being
http://localhost:8000/consumer-tools/financial-well-being/
http://localhost:8000/consumer-tools/financial-well-being/about/
http://localhost:8000/consumer-tools/financial-well-being/results/

Ask CFPB
http://localhost:8000/ask-cfpb/
http://localhost:8000/ask-cfpb/do-buy-now-pay-later-bnpl-loans-have-fees-en-2118/

D&I
http://localhost:8000/about-us/diversity-and-inclusion/voluntary-assessment-onboarding-form/
http://localhost:8000/about-us/diversity-and-inclusion/voluntary-assessment-onboarding-form/privacy-act-statement/

TDP
http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/bouncing-ball-money-choices/

Retirement
http://localhost:8000/es/herramientas-del-consumidor/jubilacion/antes-de-solicitar/

OAH/BAH Rate Explorer
http://localhost:8000/owning-a-home/explore-rates/

FAHC
http://localhost:8000/find-a-housing-counselor/

ROUT
http://localhost:8000/rural-or-underserved-tool/

iRegs
http://localhost:8000/rules-policy/regulations/1002/2023-04-19/interp-1/

FIG
http://localhost:8000/data-research/small-business-lending/filing-instructions-guide/2024-guide/

Credit Card agreements database related links - sidebar related links should NOT be jump link at mobile
http://localhost:8000/credit-cards/agreements/issuer/1st-advantage-federal-credit-union/

Info Unit Groups
http://localhost:8000/about-us/

Featured Content
http://localhost:8000/consumer-tools/credit-reports-and-scores/consumer-reporting-companies/

Notification
http://localhost:8000/arbitration-rule/

Text Introduction
http://localhost:8000/administrative-adjudication-proceedings/administrative-adjudication-docket/

Homepage - footer links should be unchanged.
http://localhost:8000/

Notes and todos

The new behavior of jump links vertically centers the external link icon after the text, so if the link is very long, it'll end up on the right-hand side. We should probably encourage shorter links if that's an issue. I think it improves cases like this though:

Before:
Screenshot 2024-05-31 at 5 25 29 PM

After:
Screenshot 2024-05-31 at 5 25 38 PM

@@ -120,6 +120,10 @@
top: 0;
align-self: start;

// This puts the secondary nav behind the mega menu hamburger menu,
// but above other things on the page.
z-index: 9;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@contolini is this change for FIG sticky nav OK?

@anselmbradford anselmbradford force-pushed the ans_update_jump_links branch 4 times, most recently from 2a1e467 to 2b5be64 Compare June 1, 2024 01:39
@anselmbradford anselmbradford added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 4, 2024
@anselmbradford anselmbradford added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 906dce5 Jun 4, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_update_jump_links branch June 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants