Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken highlight from homepage #8463

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

csebianlander
Copy link
Contributor

@csebianlander csebianlander commented Jun 11, 2024

Right now one of the three highlights under the hero on the homepage links to page that no longer exists. This PR removes that highlight entirely and modifies the template HTML so that the two remaining items are spaced properly.

For similar reasons (broken/outdated links), this PR removes both "feature" items on the Spanish homepage.


How to test this PR

  1. localhost
  2. view /
  3. view /es

Screenshots

Before After
Screenshot 2024-06-11 at 11 50 42 AM Screenshot 2024-06-11 at 11 50 49 AM

Notes and todos

  • A replacement for that highlight page is in development; once it's live, we'll have a follow-up to this PR restoring the three-column layout and adding that third highlight back.

@marteki
Copy link
Member

marteki commented Jun 11, 2024

Thank you for doing this! I mentioned the circular link to the folks who are developing the replacement, but wasn't sure how to push further that the circular link should be dealt with sooner rather than later.

@csebianlander csebianlander added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 678aa37 Jun 11, 2024
12 checks passed
@csebianlander csebianlander deleted the homepage_fix_20240611 branch June 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants