Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace content__wrapper with wrapper #8470

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Jun 13, 2024

content__wrapper does nothing more than extend wrapper, see https://github.com/cfpb/design-system/blob/6b566bdb7ae2ce4c80a1cd05404bf3ea2e8fe6fa/packages/cfpb-layout/src/cfpb-layout.less#L117

This creates content__wrapper--match-content (since there's a wrapper--match-content class), which is entirely unused. Also, the wrapper is sometimes used outside the context of content block.

This PR replaces instances of content__wrapper with wrapper.

Changes

  • Replace content__wrapper with wrapper

How to test this PR

  1. The brand header in http://localhost:8000/owning-a-home/explore-rates/ should be unchanged, for example.

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@anselmbradford anselmbradford added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 0daad89 Jun 26, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_merge_wrapper branch June 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants