DF-2204 - Creates time macro, breaks apart format macros #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
force-pushed
the
time-template
branch
from
ff42fbf
to
cf09964
Compare
| {% if show_only.timezone == true %} | ||
| {{ format_time(datetime, timezone) }}</span> | ||
| {% else %} | ||
| {{ format_time(datetime) }}</span> |
There was a problem hiding this comment.
Shouldn't closing tag be outside of if statement?
There was a problem hiding this comment.
Fixed in b10968c Also, the divider shouldn't have been enclosed in the time element.
|
I'm going through to check how they render on all these and the attention to detail on all these |
|
The example shown look great. I would wait on the history example since we have a revised design for that page. |
|
👍 |
anselmbradford
force-pushed
the
time-template
branch
from
5cdae78
to
70f8fe1
Compare
anselmbradford
force-pushed
the
time-template
branch
from
70f8fe1
to
2ebca64
Compare
anselmbradford
added a commit
that referenced
this pull request
Aug 11, 2015
DF-2204 - Creates time macro, breaks apart format macros
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates time macro and converts datetime instances to use time macro. Also, breaks apart format macro into topical macros.
Additions
Changes
Testing
/activity-log/,/events/,/events/summer-consumer-advisory-board-meeting-in-omaha-ne/,/blog/,/blog/forum-on-know-before-you-owe-eclosing-pilot/,/the-bureau/leadership-calendar/,/offices/payments-to-harmed-consumers/,/careers/,/careers/current-openings/,/careers/current-openings/1873/Review
Screenshots
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
This PR:
On beta:
[JOB POSTING NOT AVAILABLE ON BETA]
This PR:
Todos
/the-bureau/history/are not fed into the macro. Should they be?