This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Type spacing updates #381
Merged
Type spacing updates #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update copy, example images, and compiled CSS for showing our new type spacing rules. - Remove images that are no longer used. - Change all instances of "header" to "heading" - Rename Web "subheading" to "lead paragraph"
|
|
||
| <p>Consistent scaling, weights, and capitalization are used to create distinction between header levels. They provide the user with a familiar focus point when they scan through text and it helps organize content. Headers are used in three weights of Avenir Next Demi Bold, Medium, and Regular.</p> | ||
| <p>Consistent scaling, weights, and capitalization are used to create distinction between heading levels. They provide the user with a familiar focus point when they scan through text and it helps organize content. Headings are used in three weights of Avenir Next Demi Bold, Medium, and Regular.</p> |
There was a problem hiding this comment.
You don't need p tags here do you?
There was a problem hiding this comment.
Technically, no, but they're all over, and they don't do any harm, so I'll just leave 'em.
|
One small comment, otherwise 👍 |
|
Whoops, running this locally and "Display Heading" and "Lead Paragraph" aren't rendering
|
|
Have you installed the latest cf-core?
|
|
Ha, you'd think I'd know that seeing how I made that point last week. Must be Monday. Looks good 👍 from me again. |
|
@cfarm @KimberlyMunoz @ascott1 anyone else want to sign off on this? |
|
@nataliafitzgerald gave me a verbal thumbs-up to this last week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for our latest type spacing guidelines.
Additions
Removals
Changes
Testing
Review
Checklist